|
2022-12-26 11:37 developer |
vold.jpg (27,825 bytes) CtsScopedStorageDeviceOnlyTest-pass.jpg (95,555 bytes) CtsScopedStorageDeviceOnlyTest-fail.jpg (188,641 bytes) |
|
|
Hi Jason I reported this issue to SPTEK https://jira.skbroadband.com/browse/FSTB12-25 Thank you YK.Jung |
|
|
Hi Jason This issue is not occurring in other manufacturers. only observed on FXN models. (FYI, the vold side is implemented by each manufacturer.) First of all, the patch was modified by SPTEK and FXN at ATV10. and SPTEK applied the patch to ATV12. So we need to know if it was caused by the modification of FXN or the modification of SPTEK. Please check the cause of this issue and let me know. Thank you YK.Jung |
|
|
Hi Younkwang From CTS failed log, it shows some error message about setuping storage directory : I/ModuleListener: [8/230] android.scopedstorage.cts.device.BypassDatabaseOperationsTest#testManageExternalStorage_DoesntBypassDatabase_afterS[volume=volume_public] FAILURE: Could not setup default dir [/storage/0BEF-1311/Alarms] expected to be true So I disable only "USB mount point name" part of Sptek modification and try again: system/vold/model/PublicVolume.cpp: @@ -143,7 +143,7 @@ status_t PublicVolume::doMount() { stableName = "sdcard3"; #endif -#if 1 //SPTEK: Change USB mount point name to sdcard# +#if 0 //SPTEK: Change USB mount point name to sdcard# //const std::string DEFAULT_MOUNT_NAME("/storage/sdcard"); const std::string DEFAULT_MOUNT_NAME("/mnt/media_rw/sdcard"); int nIndex=1; then the CTS module passes. And we find that AVT10 CTS doesn't have this test module, so there is no problem on ATV10. Could you take a other vendor's device (ATV12) to test this module for make sure they can pass this test? |
|
|
Hi Sam I reported it to SPTEK Thank you YK.Jung |
|
|
Hi Sam This fail occurs if the mount name is changed from original uuid to sdcard. If FW use the original uuid for the mount name, this test is passed However, some apps that use the "sdcard" path have problems. To satisfy both cases, SPTEK is considering the following. - only change uuid to sdcard when actual usb device is connected - Use uuid as it is when the actual usb device is not connected (for Google test) SPTEK think that this test case does not actually connect usb devices. Is it correct? Thank you YK.Jung |
|
|
Hi Younkwang Yes, correct. It doesn't need to connect actually USB devices. Thanks~ |
|
|
Hi Sam SPTEK is currently reviewing UUID. but , the problem is that if SPTEK modify it with UUID, some other apps need to be modified.(this takes a long time.) First of all, SPTEK/SKB would like to modify it to WK by checking whether the Physical USB is connected or not That is, SPTEK thinks as follows. if [check Physical usb connection] == yes change UUID to sdcard else use UUID [for goolge test] Please check how SPTEK can know that USB is physically connected. Thank you YK.Jung |
|
|
Hi YK, I think they can use the storage label(name) to know the storage is physical or not. Like logs below show, the physical storage device has a label name "CUBES", but the virtual one's is null: physical device: 01-06 19:04:02.857 3130 3378 D vold : -->serno= 08B2-D6E6, label_len=5, label = CUBES 01-06 19:04:02.857 3130 3378 D vold : HAVE_DLOPEN -->ret= 1, fat usb label = CUBES 01-06 19:04:02.857 3130 3378 D vold : /dev/block/vold/public:8,1: LABEL="CUBES" UUID="08B2-D6E6" TYPE="vfat" 01-06 19:04:02.859 3130 3378 D vold : /system/bin/fsck_msdos 01-06 19:04:02.859 3130 3378 D vold : -p virtual: 12-28 11:43:58.638 root 3130 11007 D vold : -->serno= 0BEF-1311, label_len=0, label = (null) 12-28 11:43:58.638 root 3130 11007 D vold : /dev/block/vold/public:7,1: UUID="0BEF-1311" TYPE="vfat" 12-28 11:43:58.639 root 3130 11007 D vold : /system/bin/fsck_msdos 12-28 11:43:58.640 root 3130 11007 D vold : -p Thanks~ Sam |
|
|
Hi Sam I checked the method. I connected the USB device to the Window PC and deleted the name of the USB device. Then, I connected the USB device to STB and found that the label was (null). In other words, the label name can also be displayed as null when you connect the physical usb device. Please check again if there is a way to check it accurately. Thanks YK.Jung physical_usb_connect.PNG (166,253 bytes) |
|
|
Hi YK I think the method of recognizing "label" doesn't work well. There are two other methods: 1. Recognize physical devices from UsbHostManager storage information: Because Sptek is familiar at framework, I think they can recognize physical devices from UsbHostManager service information(manufacturer name, product name,..., etc.). There are some device information in logs: "UsbHostManager: Added device UsbDevice[mName=/dev/bus/usb/002/003,mVendorId=1921,mProductId=21905,mClass=0,mSubclass=0,mProtocol=0,mManufacturerName=SanDisk,mProductName=Ultra USB 3.0,mVersion=1.00,mSerialNumberReader=com.android.server.usb.UsbSerialReader@dc7daed, mHasAudioPlayback=false, mHasAudioCapture=false, mHasMidi=false, mHasVideoCapture=false, mHasVideoPlayback=false, mConfigurations=[" 2. If Sptek can't recognize the physical devices, for work around, they can recognize the cts test is running: They can detect the apk package "android.scopedstorage.cts.device" is installed, and don't rename storage name in this condition. (12-28 10:43:21 D/TestAppInstallSetup: Installing apk android.scopedstorage.cts.device with [/home/cts_user/xTS/android-cts/tools/../../android-cts/testcases/CtsScopedStorageDeviceOnlyTest.apk] ...) Thanks~ Sam |
|
|
Hi Sam The today meeting with SKB just ended. it has been decided that all contents related to vold will be changed from sdcard to uuid. SPTEK will modify it. And as far as I know, attdaemon uses sdcard string. I think FXN just need to modify the attdaemon afterwards. Thank you YK.Jung |
|
|
Hi Sam SPTEK is verifying that it changed to UUID and SPTEK will commit after verification is completed. I'll let you know when SPTEK commits. Thank you YK.Jung |
|
|
Hi Sam The code to change to sdcard was removed from SPTEK. All parts(doUnmount.. etc. ) of FXN code that access sdcard need to be changed. Please check it Thank you YK.Jung vold.PNG (34,519 bytes) |
|
|
Hi YK, OK, I'll check it. Thanks~ Sam |
|
|
Hi YK, The issue is fixed, thanks. Sam |
|
|
Confirm with version "537r03". |
- yk.jung ( (ALTech) Younkwang Jung ) developer
